Skip to content

Fix the fix for interactivity polling not actually working

Mateusz Brawański requested to merge github/fork/uwx/patch-83 into master

Created by: uwx

Summary

Fixes the fix for interactivity polling not having the intended effect, thus making the fix not work.

Details

Explained in Python:

This is what the code was supposed to mean:

if member is reacting in a different message:
  dont remove the reaction
if member reacting is the bot:
  dont remove the reaction

otherwise remove the reaction

This is what it actually does, at the moment:

if member is reacting in a different message and member reacting is the bot:
  dont remove the reaction

otherwise remove the reaction

The misleading fix was caused by idiot programmer (me).

Changes proposed

  • Replace the && in ReactionAddHandler for polling in Interactivity with a ||

Notes

Yes, I tested it this time.

Merge request reports

Loading