Edit Entities for Create and Modify to use individual builders
Created by: jeffreyladd
Summary
Updates many of the Create/Modify Entities to use builders. I also have seperated the builders so they only do Modify or Create.
Changes Done
- DiscordGuild Create
- Adds missing params on the Create Payload
- Simplifies the API to use a builder/Action of a Builder.
- Centralizes the validation
- DiscordGuild Modify
- Adds missing params on the modify payload
- Simplifies the API to use a builder and reduces the Methods.
- Centralizes the validation
- DiscordChannel Create
- Simplifies the API to use a builder and also reduces the amount over Methods and overloads to do one task.
- Centralizes the validation
- DiscordChannel Modify
- Simplifies the API to use a builder and also reduces the amount over Methods and overloads to do one task.
- Centralizes the validation
- DiscordRole Create
- Simplifies the API to use a builder and also reduces the amount over Methods and overloads to do one task.
- Centralizes the validation
- DiscordRole Modify
- Simplifies the API to use a builder and also reduces the amount over Methods and overloads to do one task.
- Centralizes the validation
- DiscordMember Modify
- Simplifies the API to use a builder and also reduces the amount over Methods and overloads to do one task.
- Centralizes the validation
- Gluid Membership screening Modify
- Simplifies the API to use a builder and also reduces the amount over Methods and overloads to do one task.
- Centralizes the validation
Tests Done
- Wrote Tests that validate the Guild Create Using the Builder. Also wrote Tests that validate the Guild Create using an action of a builder.
- There is a bug on the discord API side where passing a system_channel_id or afk_channel_id will cause a Server Exception. This is due to them not handling the mapping correctly.
- Wrote Tests that validate the Guild Modify Using the Builder. Also wrote Tests that validate the Guild Modifyusing an action of a builder.
- Wrote and organized tests that validate everything you can do with the MessageCreate Builder and MessageModifyBuilder.
- Wrote Tests that validate the Channel Create using the Builder. Also wrote tests that validate the Channel Create using an action of a builder
- Wrote Tests that validate the Channel Modify using the Builder. Also wrote tests that validate the Channel modify using an action of a builder
- Wrote Tests that validate the Role Create using the Builder. Also wrote tests that validate the Role Create using an action of a builder
- Wrote Tests that validate the Role Modify using the Builder. Also wrote tests that validate the Role modify using an action of a builder
- Wrote Tests that validate the Member Modify using the Builder. Also wrote tests that validate the Member modify using an action of a builder
- Wrote Tests that validate the GuildMembership Modify using the Builder. Also wrote tests that validate the GuildMembership modify using an action of a builder
- For this i currently dont have the facilities to test this for some reason. I keep on getting a access denied permission from discord. Dunno what that is about.
Items left to do
- Finish writing tests
- Update Documentation where we changed the logic
- Create Developer Documentation when it comes in terms of writing a builder and the format they should follow to make things consistent.