Skip to content

The Great Formattening™

Mateusz Brawański requested to merge feature/editorconfig into master

Summary

Introduces .editorconfig and reformats the entire codebase. That's right, all of it.

Details

Since there was no opposition in D#+, I've gone ahead and implemented my draconian .editorconfig file, for everyone to hate and cry about. It introduces a lot of strict formatting rules. I then went and painstakingly fixed all parenthesis and null/pattern match violations because dotnet format just crashes instead of fixing them. The config also now hopefully adds a file header with license info to new files.

Changes not covered by it include:

  • newline + 1 indent for expression bodies
  • breaking up ternaries into line + 1 indent
  • perhaps other things?

The code is now roughly reformatted. Oh, and I updated license years, even though that's a very worthless change.

With this newfound tears, our codebase will now be more style- and formatting-consistent.

Changes proposed

  • Add .editorconfig
  • Update license files
  • Reformat the entire codebase

Notes

dotnet-format is kinda bad tbh. I am not redoing this for release/4.x branch.

Merge request reports