Skip to content

Fix quality mode errors

Mateusz Brawański requested to merge github/fork/ProfDoof/fix_quality_mode_errors into master

Created by: ProfDoof

Summary

Fixes bug found here with QualityMode being an unaccepted value by Discord. Also fixes a few problems with Naming Rule Violations.

Details

There was a bug in the way that we were handling VideoQualityMode which caused channels to be created incorrectly when cloning channels. VideoQualityMode was not nullable. The couple of places that accepted a VideoQualityMode also used a default value of default instead of null which while it technically gives the desired behavior is not as clear as null is as to what the default value being put in is.

Changes proposed

  • Switched from using default as the default value to using null for clarity.
  • Made DiscordChannel#QualityMode nullable so that when parsed it isn't set equal to 0 but instead null.
  • Added testing commands to ensure that the changes didn't break anything.
  • Fix Naming Rule Violations

Notes

N/A

Merge request reports